From 0e266671f9ec371df9d076435b580aa8493c4438 Mon Sep 17 00:00:00 2001
From: Francois <thiebolt@irit.fr>
Date: Tue, 16 Aug 2022 08:28:51 +0200
Subject: [PATCH] missing return in function
---
neosensor/libraries/neocampus_drivers/TM1637Display.cpp | 2 +-
neosensor/libraries/neocampus_drivers/TM1637Display.h | 2 +-
neosensor/libraries/neocampus_modules/display.cpp | 2 +-
neosensor/libraries/neocampus_modules/display.h | 2 +-
neosensor/libraries/neocampus_modules/neoclock.cpp | 3 ++-
neosensor/libraries/neocampus_modules/neoclock.h | 2 +-
neosensor/libraries/neocampus_modules/noise.cpp | 4 ++--
7 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/neosensor/libraries/neocampus_drivers/TM1637Display.cpp b/neosensor/libraries/neocampus_drivers/TM1637Display.cpp
index 0f466d5c..07ff0815 100644
--- a/neosensor/libraries/neocampus_drivers/TM1637Display.cpp
+++ b/neosensor/libraries/neocampus_drivers/TM1637Display.cpp
@@ -450,7 +450,7 @@ uint8_t TM1637Display::_computePercentBrightness( uint8_t percent ) {
/*
* 0.5s timer handler to manage central dots blinking
*/
-void ICACHE_RAM_ATTR TM1637Display::timerHandler( TM1637Display *p ) {
+void IRAM_ATTR TM1637Display::timerHandler( TM1637Display *p ) {
// animation mode is exclusive with normal mode (i.e central leds blinking)
if( p->_animMode != displayAnimate_t::stop ) {
diff --git a/neosensor/libraries/neocampus_drivers/TM1637Display.h b/neosensor/libraries/neocampus_drivers/TM1637Display.h
index 5c090ff2..e56ba0ac 100644
--- a/neosensor/libraries/neocampus_drivers/TM1637Display.h
+++ b/neosensor/libraries/neocampus_drivers/TM1637Display.h
@@ -148,7 +148,7 @@ class TM1637Display : public driver_display {
bool setDotsBlinking( bool );
// Every half-second timer call to this method for central dots blinking
- static void ICACHE_RAM_ATTR timerHandler( TM1637Display * );
+ static void IRAM_ATTR timerHandler( TM1637Display * );
/* ------------------------------------------
diff --git a/neosensor/libraries/neocampus_modules/display.cpp b/neosensor/libraries/neocampus_modules/display.cpp
index 54b76092..4397111b 100644
--- a/neosensor/libraries/neocampus_modules/display.cpp
+++ b/neosensor/libraries/neocampus_modules/display.cpp
@@ -544,7 +544,7 @@ bool display::saveConfig( void ) {
* 1s timer handler
* Note: interrupt handler, no serial debug messages !
*/
-void ICACHE_RAM_ATTR display::timerHandler( display *p ) {
+void IRAM_ATTR display::timerHandler( display *p ) {
if( p->_secondsLeft-- ) return;
diff --git a/neosensor/libraries/neocampus_modules/display.h b/neosensor/libraries/neocampus_modules/display.h
index ca247eee..ead7accc 100644
--- a/neosensor/libraries/neocampus_modules/display.h
+++ b/neosensor/libraries/neocampus_modules/display.h
@@ -85,7 +85,7 @@ class display : public base {
// Handlers
// Every second timer call to this method
- static void ICACHE_RAM_ATTR timerHandler( display * );
+ static void IRAM_ATTR timerHandler( display * );
// animation
bool animate( displayAnimate_t mode=displayAnimate_t::demo );
diff --git a/neosensor/libraries/neocampus_modules/neoclock.cpp b/neosensor/libraries/neocampus_modules/neoclock.cpp
index ce4ad9d5..36b7b41f 100644
--- a/neosensor/libraries/neocampus_modules/neoclock.cpp
+++ b/neosensor/libraries/neocampus_modules/neoclock.cpp
@@ -64,6 +64,7 @@ bool neoclock::add_display( uint8_t id ) {
};
log_info(F("\n[neoclock] successfully added display_id ")); log_info(id,DEC); log_flush();
+ return true;
}
@@ -172,7 +173,7 @@ bool neoclock::process( void ) {
* 1s timer handler
* Note: interrupt handler, no serial debug messages !
*/
-void ICACHE_RAM_ATTR neoclock::timerHandler( neoclock *p ) {
+void IRAM_ATTR neoclock::timerHandler( neoclock *p ) {
if( p->_secondsLeft-- ) return;
diff --git a/neosensor/libraries/neocampus_modules/neoclock.h b/neosensor/libraries/neocampus_modules/neoclock.h
index 81aa88a3..7b47ab9b 100644
--- a/neosensor/libraries/neocampus_modules/neoclock.h
+++ b/neosensor/libraries/neocampus_modules/neoclock.h
@@ -72,7 +72,7 @@ class neoclock : public base {
// Handlers
// Every second timer call to this method
- static void ICACHE_RAM_ATTR timerHandler( neoclock * );
+ static void IRAM_ATTR timerHandler( neoclock * );
// animation
bool animate( displayAnimate_t mode=displayAnimate_t::demo );
diff --git a/neosensor/libraries/neocampus_modules/noise.cpp b/neosensor/libraries/neocampus_modules/noise.cpp
index 959d2c4c..9c8f2814 100644
--- a/neosensor/libraries/neocampus_modules/noise.cpp
+++ b/neosensor/libraries/neocampus_modules/noise.cpp
@@ -325,7 +325,7 @@ bool noise::process( void ) {
* Sliding Window for noise pulse count:
* timer handler method called EVERY SECOND
*/
-void ICACHE_RAM_ATTR noise::timerHandler( noise *p ) {
+void IRAM_ATTR noise::timerHandler( noise *p ) {
uint8_t _curNoiseEntry, nextNoiseEntry;
@@ -367,7 +367,7 @@ void ICACHE_RAM_ATTR noise::timerHandler( noise *p ) {
* This method called upon interrup on _pinSensor
* will increment noiseTab[curNoiseEntry]
*/
-void ICACHE_RAM_ATTR noise::noiseDetectISR( void ) {
+void IRAM_ATTR noise::noiseDetectISR( void ) {
// static uint8_t _curNoiseEntry = -1;
--
GitLab