Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
B
batmen
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
sepia-pub
mael
batmen
Commits
30716247
Commit
30716247
authored
2 years ago
by
Maël Madon
Browse files
Options
Downloads
Patches
Plain Diff
dev: it's a max and not a min in close_session()
parent
60ccb7aa
No related branches found
No related tags found
1 merge request
!2
Feature "replay with feedback" ready and tested
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/broker/user_feedback.cpp
+1
-1
1 addition, 1 deletion
src/broker/user_feedback.cpp
src/json_workload.hpp
+3
-1
3 additions, 1 deletion
src/json_workload.hpp
with
4 additions
and
2 deletions
src/broker/user_feedback.cpp
+
1
−
1
View file @
30716247
...
...
@@ -111,7 +111,7 @@ void FBUserThinkTimeOnly::close_session(double date, Session *finished_session)
s
->
start_time
=
date
+
tt_after_finished_session
;
else
s
->
start_time
=
std
::
m
in
(
s
->
start_time
,
date
+
tt_after_finished_session
);
=
std
::
m
ax
(
s
->
start_time
,
date
+
tt_after_finished_session
);
s
->
preceding_sessions
.
erase
(
finished_session
);
...
...
This diff is collapsed.
Click to expand it.
src/json_workload.hpp
+
3
−
1
View file @
30716247
...
...
@@ -69,7 +69,9 @@ struct Session
double
original_first_submit_time
;
/* the submit time of the first job in this
session, as in the original trace */
double
start_time
;
/* the submit time of the first job in this session, as in the replay with feedback. Also used to store the projected start time. */
double
start_time
;
/* the submit time of the first job in this session, as
in the replay with feedback. Also used to store the
projected start time. */
unsigned
int
unfinished_jobs
;
std
::
list
<
Job
*>
jobs
;
// TODO: job Queue instead? To think...
std
::
map
<
Session
*
,
double
>
preceding_sessions
;
/* pair (Session, t_time) */
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment